apollo_integration_tests: make metrics recorder init global in flow tests #9488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
itamar-starkware
force-pushed
the
10-05-apollo_integration_tests_make_metric_recorder_init_global
branch
from
b87fe2b to
9a1238c
Compare
itamar-starkware
changed the title
ArniStarkware
requested changes
Oct 8, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5)
crates/apollo_integration_tests/tests/common/mod.rs line 140 at r1 (raw file):
let metrics = handle.render(); apollo_batcher::metrics::BATCHED_TRANSACTIONS.parse_numeric_metric::<usize>(&metrics).unwrap() }
This function specifically expects a prometheusHandle of a recorder, correct?
Also - be consistent with assert_full_blocks_flow
Suggestion:
fn get_total_batched_txs_count(recorder_handle: &PrometheusHandle) -> usize {
let metrics = recorder_handle.render();
apollo_batcher::metrics::BATCHED_TRANSACTIONS.parse_numeric_metric::<usize>(&metrics).unwrap()
}
itamar-starkware
force-pushed
the
10-05-apollo_integration_tests_make_metric_recorder_init_global
branch
from
9a1238c to
7ee1793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change metric recorder to be global.
In the next PR we wil use different tokio runtime across different OS threads so we need a global metric handler for aligned results.